Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR for appcat on fix/bucket_protection #485

Merged
merged 2 commits into from
Sep 19, 2024
Merged

PR for appcat on fix/bucket_protection #485

merged 2 commits into from
Sep 19, 2024

Conversation

vshnbot
Copy link
Collaborator

@vshnbot vshnbot commented Sep 18, 2024 •
edited by Kidswiss
Loading

Summary

  • There was a casting error in the code, which made the deletion check fail at runtime

Checklist

  • Categorize the PR by setting a good title and adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog
  • Update tests.
  • Link this PR to related issues.

Link: vshn/appcat#233

@Kidswiss Kidswiss added the patch label Sep 19, 2024
@Kidswiss Kidswiss merged commit f1bd747 into master Sep 19, 2024
27 checks passed
@Kidswiss Kidswiss deleted the appcat/233/fix/bucket_protection branch September 19, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kidswiss Kidswiss Kidswiss approved these changes

Assignees
No one assigned
Labels
patch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vshnbot @Kidswiss