Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Crossplane namespace input #527

Merged
merged 1 commit into from
Nov 7, 2024
Merged

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Nov 6, 2024

This input is needed for the comp function to determine the right Crossplane namespace. This is important for various things, like proper netpols for the providers, to be able to connect to the instance.

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@Kidswiss Kidswiss added the patch label Nov 6, 2024
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team November 6, 2024 08:52
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

This input is needed for the comp function to determine the right
Crossplane namespace. This is important for various things, like proper
netpols for the providers, to be able to connect to the instance.
@Kidswiss Kidswiss merged commit b7989ad into master Nov 7, 2024
28 checks passed
@Kidswiss Kidswiss deleted the fix/crossplane_namespace branch November 7, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants