Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase memory limits #531

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Increase memory limits #531

merged 1 commit into from
Nov 12, 2024

Conversation

Kidswiss
Copy link
Contributor

@Kidswiss Kidswiss commented Nov 12, 2024

Increases memory limits for envoy and pgbouncer

Checklist

  • The PR has a meaningful title. It will be used to auto generate the
    changelog.
    The PR has a meaningful description that sums up the change. It will be
    linked in the changelog.
  • PR contains a single logical change (to build a better changelog).
  • Categorize the PR by adding one of the labels:
    bug, enhancement, documentation, change, breaking, dependency
    as they show up in the changelog.
  • Link this PR to related issues or PRs.

@Kidswiss Kidswiss added the patch label Nov 12, 2024
Increase envoy and pgbouncer memory limits
@Kidswiss Kidswiss requested review from a team, TheBigLee, wejdross and zugao and removed request for a team November 12, 2024 08:30
Copy link
Contributor

@zugao zugao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wejdross
Copy link
Member

please verify in LAB that those request/limits are not violate fair usage ratio
LGTM

@Kidswiss
Copy link
Contributor Author

Kidswiss commented Nov 12, 2024

please verify in LAB that those request/limits are not violate fair usage ratio LGTM

Looks good on the lab, however, the init containers violate the ratio. But given that they only run for a few seconds during startup they don't really affect it very much.

EDIT: it's not actually the initcontainers, they don't count, but the container that triggers the actual restart of the main pod. So even less of an impact.

@Kidswiss Kidswiss merged commit 81c131e into master Nov 12, 2024
28 checks passed
@Kidswiss Kidswiss deleted the fix/more_limits branch November 12, 2024 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants