Disallow misuse of ucl_object_emit_streamline_start_container

Issue: #300 Closes: #300
vstakhov · Apr 24, 2024 · 37edb29 · 37edb29
1 parent f897d5a
commit 37edb29
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 3 deletions.
diff --git a/include/ucl.h b/include/ucl.h
@@ -1494,7 +1494,7 @@ UCL_EXTERN struct ucl_emitter_context* ucl_object_emit_streamline_new (
  * @param ctx streamlined context
  * @param obj container object
  */
-UCL_EXTERN void ucl_object_emit_streamline_start_container (
+UCL_EXTERN bool ucl_object_emit_streamline_start_container (
 		struct ucl_emitter_context *ctx, const ucl_object_t *obj);
 /**
  * Add a complete UCL object to streamlined output

diff --git a/src/ucl_emitter_streamline.c b/src/ucl_emitter_streamline.c
@@ -87,7 +87,7 @@ ucl_object_emit_streamline_new (const ucl_object_t *obj,
 	return (struct ucl_emitter_context *)sctx;
 }
 
-void
+bool
 ucl_object_emit_streamline_start_container (struct ucl_emitter_context *ctx,
 		const ucl_object_t *obj)
 {
@@ -113,12 +113,20 @@ ucl_object_emit_streamline_start_container (struct ucl_emitter_context *ctx,
 			st->is_array = true;
 			sctx->ops->ucl_emitter_start_array (ctx, obj, top == NULL, print_key);
 		}
-		else {
+		else if (obj != NULL && obj->type == UCL_OBJECT) {
 			st->is_array = false;
 			sctx->ops->ucl_emitter_start_object (ctx, obj, top == NULL, print_key);
 		}
+		else {
+			/* API MISUSE */
+			free (st);
+
+			return false;
+		}
 		LL_PREPEND (sctx->containers, st);
 	}
+
+	return true;
 }
 
 void