Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix messagepack EXT parsing #306

Merged
merged 2 commits into from
Apr 25, 2024
Merged

Fix messagepack EXT parsing #306

merged 2 commits into from
Apr 25, 2024

Conversation

vstakhov
Copy link
Owner

@vstakhov vstakhov commented Apr 25, 2024 •
edited
Loading

When we read ext we actually do not get any object, so we MUST NOT insert parser->cur_obj multiple times, as we will have use-after-free on unref. This is a serious bug.

Issue: #303, #302
Closes: #303, #302

@vstakhov
Fix messagepack EXT parsing
047b02b 
When we read `ext` we actually do not get any object, so we MUST NOT
insert `parser->cur_obj` multiple times, as we will have use-after-free
on unref. This is a serious bug.

Issue: #303
Closes: #303
@vstakhov
Apply the same fix in other places of the parser
1e409ae
@vstakhov vstakhov merged commit 5c58d0d into master Apr 25, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

heap-use-after-free at line 277 in ucl_util.c
1 participant
@vstakhov