fix: poor INP when opening drawer for the first time

vtex-apps · Nov 13, 2024 · 8cb5c01 · 8cb5c01
1 parent 0ec8c5f
commit 8cb5c01
Showing 1 changed file with 8 additions and 4 deletions.
diff --git a/react/Drawer.tsx b/react/Drawer.tsx
@@ -187,13 +187,17 @@ function Drawer(props: Props) {
   )
 
   const overlayVisible = backdropMode === 'visible' && isMenuOpen
-  
+
   useEffect(() => {
-    if (isMenuOpen || hasMenuBeenOpened || renderingStrategy === 'eager'){
+    if (isMenuOpen || hasMenuBeenOpened || renderingStrategy === 'eager') {
       setShouldRenderChildren(true)
     }
-  },
-  [hasMenuBeenOpened, renderingStrategy, setShouldRenderChildren, isMenuOpen])
+  },[
+    hasMenuBeenOpened,
+    renderingStrategy,
+    setShouldRenderChildren,
+    isMenuOpen
+  ])
 
   return (
     <DrawerContextProvider value={contextValue}>