Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CustomErrorMessage #60

Open
wants to merge 2 commits into
base: 1.x
Choose a base branch
from

Conversation

TiagoGranelli
Copy link

@TiagoGranelli TiagoGranelli commented Feb 8, 2022

What is the purpose of this pull request?

The purpose of this PR is so that it is possible to pass a custom text as a property to the error alert in MyAccount

This PR depends on this:
vtex-apps/my-account#252
Please, to review this PR and understand why it exists, read the PR above

What problem is this solving?

We are passing the customErrorMessage prop so that we can choose to change the generic alert message that is generated when an error occurs in MyAccount

To understand better, read this PR:
vtex-apps/my-account#252

How should this be manually tested?

Following in the footsteps of this PR: vtex-apps/my-account#252

Screenshots or example usage

image

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

@vtex-io-ci-cd
Copy link

vtex-io-ci-cd bot commented Feb 8, 2022

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot
Copy link

Beep boop 🤖

Thank you so much for keeping our documentation up-to-date ❤️

@TiagoGranelli TiagoGranelli changed the base branch from master to 1.x February 8, 2022 17:04
@TiagoGranelli TiagoGranelli marked this pull request as ready for review February 8, 2022 22:57
@TiagoGranelli TiagoGranelli changed the title Feature/document validate CustomErrorMessage Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants