-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added variant to facets query #682
Conversation
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
But there's also an issue that I see recurring regarding breaking SSR when new fields are added to these queries. @hiagolcm has more information on it, I'd wait for his review.
By testing the workspace I didn't identify the problem happening. So we are good |
What is the purpose of this pull request?
Depends on: vtex-apps/store-resources#187
What problem is this solving?
How should this be manually tested?
Workspace
Screenshots or example usage
Types of changes