Fix: Integration and enable back accessibility tests - Updates @faststore/cli to 3.0.115 #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
hellofanny
changed the title
hellofanny
added a commit
to vtex/faststore
that referenced
this pull request
Sep 26, 2024
## What's the purpose of this pull request? - Updates pdp product link for tests and updates tests to adapt to new product <img width="369" alt="image" src="https://github.com/user-attachments/assets/d44ea604-3f02-4902-a709-7b8c670693be"> The product we were testing is OutOfStock and does not have the expected ID. We switched to another product and updated the other tests accordingly." - Puts back `cy.checkA11y` for home page, collection page and product page. (a11y.test.js) - Fix automatic accessibility issues & improves overall ## How it works? This PR, should fix the failing tests below: <img width="1024" alt="image" src="https://github.com/user-attachments/assets/d2c2b4f3-dc63-4290-8bfc-74461c30a377"> <img width="1168" alt="image" src="https://github.com/user-attachments/assets/1c56bd29-7a70-4389-afcd-f7d44b9c0e89"> <img width="1004" alt="image" src="https://github.com/user-attachments/assets/ff61bf08-45b6-4b9a-8f9a-813388cf8e16"> ## How to test it? 1. You can test using this [PR](vtex-sites/starter.store#535), the integration test all should be passing. <img width="718" alt="image" src="https://github.com/user-attachments/assets/f233714c-3fe3-4d98-a924-3cc6ea344ada"> 2. Run the core locally, then run `yarn test`. All the tests should pass. ### Starters Deploy Preview vtex-sites/starter.store#535 ### References https://dequeuniversity.com/rules/axe/4.10/region?application=AxeChrome
hellofanny
changed the title
hellofanny
changed the title
hellofanny
force-pushed
the
fix/integration-tests
branch
from
47361d3
to
eb6934c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
Adds the following changes:
1cc987d [no ci] Release: 3.0.115
2d6d89e Fix: Integration and enable back accessibility tests (#2458)
Updates the PDP product path in
faststore.config.jsNote:
Unfortunately, these accessibility testes are failing again, although it was passing before. We'll fix it in another version and proceed with this update.