Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove hidden value for postalCode #588

Closed
wants to merge 1 commit into from
Closed

Conversation

rbussola
Copy link

Remove hidden value for postalCode, so the field is shown in the Checkout UI

What is the purpose of this pull request?

This change will make the postal code input to be shown in the Chekout UI.

What problem is this solving?

Before:
image

After:
image

How should this be manually tested?

https://ki312132--vtexgame1clean.myvtex.com/checkout/cart/add/?sku=312&qty=1&seller=1&sc=2
Select United Arab Emirates

Types of changes

  • [ X ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Remove hidden value for postalCode, so the field is shown in the Checkout UI
@rbussola rbussola requested a review from a team as a code owner June 21, 2024 16:06
Copy link
Contributor

vtex-io-ci-cd bot commented Jun 21, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@rbussola
Copy link
Author

They can't use postal code :(

@rbussola rbussola closed this Jun 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant