Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid optional field at my account for Postal Code #604

Merged
merged 3 commits into from
Aug 30, 2024

Conversation

beatrizmaselli
Copy link
Contributor

What is the purpose of this pull request?

When adding a new address inside my account the user is presented today with a field that is mandatory but the interface point it as optional. Example:

image image

After Change:
image

image

What problem is this solving?

This makes the interface more precise and therefore more user-friendly for users.

How should this be manually tested?

Test it here: https://optionaladdress--dunnesstorespreprod.myvtex.com/

Its important not to test in master because in master you have a css currently at the theme to hide the optional text. This was removed at this beta so we can avoid this and have the right native behavior already at the address form:
[email protected]

This version is already installed at the workspace provided.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link
Contributor

vtex-io-ci-cd bot commented Aug 2, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@beatrizmaselli beatrizmaselli changed the title add required property Avoid optional field at my account for Postal Code Aug 2, 2024
@beatrizmaselli beatrizmaselli merged commit f83074e into 4.x Aug 30, 2024
7 checks passed
@beatrizmaselli beatrizmaselli deleted the Add/required-prop-postalCode-4.x branch August 30, 2024 10:50
Copy link
Contributor

vtex-io-ci-cd bot commented Aug 30, 2024

Your PR has been merged! App is being published. 🚀
Version 4.24.6 → 4.24.7

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants