Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update rules + shouldShowNumberKeyboard logic #610

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

beatrizmaselli
Copy link
Contributor

@beatrizmaselli beatrizmaselli commented Sep 13, 2024

Related to report:
https://vtexhelp.zendesk.com/agent/tickets/1098502

Rewrite the logic for shouldShowNumberKeyboard.
It was added a logic for NaN mask type to cover the use case of UK that can have different patterns like:
SW1A 1AA – Buckingham Palace, London
W1A 1AA – BBC Broadcasting House, London
EC1A 1BB – Central London
M1 1AE – Manchester
B1 1AA – Birmingham

So in order not to change the default behavior (not defining a mask should have the numeric keyboard) we return the alphanumerical board for mask defined like NaN.

image

Copy link
Contributor

vtex-io-ci-cd bot commented Sep 13, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@beatrizmaselli
Copy link
Contributor Author

Only one should be merged: #609
The other should be closed.

Copy link
Contributor

@jeffersontuc jeffersontuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rbussola rbussola requested a review from a team September 13, 2024 20:24
@jeffersontuc jeffersontuc merged commit 84598e7 into 4.x Sep 13, 2024
7 checks passed
@jeffersontuc jeffersontuc deleted the fix/shouldShowNumberKeyboard-logic branch September 13, 2024 20:26
Copy link
Contributor

vtex-io-ci-cd bot commented Sep 13, 2024

Your PR has been merged! App is being published. 🚀
Version 4.24.7 → 4.25.0

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants