Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: Required className #612

Merged
merged 4 commits into from
Oct 22, 2024
Merged

Add: Required className #612

merged 4 commits into from
Oct 22, 2024

Conversation

beatrizmaselli
Copy link
Contributor

@beatrizmaselli beatrizmaselli commented Sep 20, 2024

What is the purpose of this pull request?

Add a required className for differentiate required fields for specific country rules.

What problem is this solving?

Enable changes at the UI for final customers at edit address page.

How should this be manually tested?

https://bug3097--dunnesstorespreprod.myvtex.com/account#/addresses/new

Screenshots or example usage

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link
Contributor

vtex-io-ci-cd bot commented Sep 20, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@beatrizmaselli beatrizmaselli requested review from jeffersontuc and a team September 20, 2024 08:59
@beatrizmaselli beatrizmaselli merged commit e418f13 into 4.x Oct 22, 2024
8 checks passed
@beatrizmaselli beatrizmaselli deleted the Add/required-className branch October 22, 2024 10:36
Copy link
Contributor

vtex-io-ci-cd bot commented Oct 22, 2024

Your PR has been merged! App is being published. 🚀
Version 4.25.5 → 4.25.6

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy [email protected]

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants