feat: next/dynamic in BannerText internal components SFS-1518
#2552
+12
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
eduardoformiga
requested review from
lucasfp13 and
lariciamota
and removed request for
a team
eduardoformiga
changed the title
BannerText internal componentsBannerText internal components SFS-1518
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR is part of the performance initiative and aims to apply next/dynamic to BannerText's internal components.
How to test it?
The pages should render as before, this PR is only to prepare the components for the time that we're gonna render based on the ViewportObserver/LazyLoadingSection.
Starters Deploy Preview
Preview
https://sfj-fc3bf86--starter.preview.vtex.app/
References
POC PR