feat: split the global sections in own file #2554
Open
+40
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eduardoformiga
requested review from
hellofanny and
renatomaurovtex
and removed request for
a team
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
This was referenced Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's the purpose of this pull request?
This PR is part of the performance initiative and aims to split the global sections into its own file.
Let's initially separate the components of each page type into their own files; this will help organize the import of components by page type (in other tasks) and opens up the possibility of only importing customized components based on the page type in the future, instead of all components, as we currently do.
The idea is to stop using the
GlobalSectionscomponent in the tree of each page, but since we are not doing this for all pages yet, we’ll keep it temporarily. We will only remove the use of this component on the homepage (in another task). Once we’ve done this for all pages, we can remove this component entirely, but we will keep the functiongetGlobalSectionsData. (packages/core/src/components/cms/GlobalSections.tsx). Global sections will now be imported into the sections file of each page and passed directly toRenderSections.Starters Deploy Preview
Preview
https://sfj-923b60d--starter.preview.vtex.app/
References
POC PR