Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EDU-1024 | KR5 H2 - VTEX Headless CMS #1048

Merged
merged 39 commits into from
Dec 21, 2023
Merged

EDU-1024 | KR5 H2 - VTEX Headless CMS #1048

merged 39 commits into from
Dec 21, 2023

Conversation

Mariana-Caetano
Copy link
Contributor

@Mariana-Caetano Mariana-Caetano commented Nov 13, 2023 •
edited
Loading

Types of changes

  • New content (endpoints, descriptions or fields from scratch)
  • Improvement (make an endpoint's title or description even better)
  • Spelling and grammar accuracy (self-explanatory)

Changelog

Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?

  • Yes, I already created a release note about this change.
  • No, but I am going to.

@Mariana-Caetano Mariana-Caetano self-assigned this Nov 13, 2023
@github-actions GitHub Actions
Copy link

Thanks for your contribution. The .json file will be checked now with Spectral.

Mariana-Caetano and others added 22 commits November 13, 2023 16:12
@Mariana-Caetano
Merge branch 'master' into EDU-10324-vtex-headless-cms-intro
3ad9dee
Update generated files by portman
797c99e
@Mariana-Caetano
API overview page: reviewed, added index + params
10cc717
@Mariana-Caetano
Merge branch 'EDU-10324-vtex-headless-cms-intro' of https://github.co…
7f2ff39 
…m/vtex/openapi-schemas into EDU-10324-vtex-headless-cms-intro
@Mariana-Caetano
Updated API description
129f601
@Mariana-Caetano
Project ID endpoint: fixed openAPI error
5498ad9
@Mariana-Caetano
Get CMS page endpoint: fixed OpenAPI error
5474931
@Mariana-Caetano
Merge branch 'master' into EDU-10324-vtex-headless-cms-intro
02d8eb9
@Mariana-Caetano
Added "components" objetc to the API
c1f3a31
@Mariana-Caetano
Added a default environment
f4bf51e
@Mariana-Caetano
Merge branch 'EDU-10324-vtex-headless-cms-intro' of https://github.co…
35c6cfe 
…m/vtex/openapi-schemas into EDU-10324-vtex-headless-cms-intro
@Mariana-Caetano
Get all Content Types endpoint: fixed lint errors
bf6c16f
@Mariana-Caetano
Review endpoint: Get all Content Types
a05a2b1
@Mariana-Caetano
Endpoint review: Get all CMS pages by Content Type
a0662e2
@Mariana-Caetano
Endpoint review: Get CMS page
8414ebd
@Mariana-Caetano
Geat all content types endpoint: fixed lint errors
9eb4fa1
@Mariana-Caetano
Get all content types endpoint: fixed lint errors
b16d9d8
@Mariana-Caetano
Get all CMS pages by content type: fixed errors
6f958ad
@Mariana-Caetano
Get all CMS pages by content type: fixed errors
36f80f5
@Mariana-Caetano
Merge branch 'master' into EDU-10324-vtex-headless-cms-intro
a22e4af
@Mariana-Caetano
Fixed lint errors
1b03457
@Mariana-Caetano
Merge branch 'EDU-10324-vtex-headless-cms-intro' of https://github.co…
8191734 
…m/vtex/openapi-schemas into EDU-10324-vtex-headless-cms-intro
@Mariana-Caetano Mariana-Caetano requested a review from a team November 29, 2023 13:51
@Mariana-Caetano Mariana-Caetano marked this pull request as ready for review November 29, 2023 13:51
julia-rabello
julia-rabello requested changes Dec 1, 2023
View reviewed changes
VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
VTEX - Headless CMS API.json Show resolved Hide resolved
VTEX - Headless CMS API.json Show resolved Hide resolved
VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
Mariana-Caetano
Mariana-Caetano commented Dec 5, 2023
View reviewed changes
VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
VTEX - Headless CMS API.json Show resolved Hide resolved
julia-rabello
julia-rabello requested changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@julia-rabello julia-rabello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Na linha 102 até 104, faltou definir a estrutura dos objetos dentro do array configurations. Mesmo que isso seja customizável, vi pelo exemplo que tem alguns campos comuns, possivelmente tem campos obrigatórios dentro disso também

VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
VTEX - Headless CMS API.json Outdated Show resolved Hide resolved
julia-rabello
julia-rabello previously approved these changes Dec 21, 2023
View reviewed changes
@Mariana-Caetano Mariana-Caetano merged commit 2930e9e into master Dec 21, 2023
2 of 3 checks passed
@Mariana-Caetano Mariana-Caetano deleted the EDU-10324-vtex-headless-cms-intro branch December 21, 2023 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julia-rabello julia-rabello julia-rabello approved these changes

Assignees

@Mariana-Caetano Mariana-Caetano

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mariana-Caetano @julia-rabello