-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EDU-10351 23H2KR5 | Promotions & Taxes API #1049
EDU-10351 23H2KR5 | Promotions & Taxes API #1049
Conversation
Thanks for your contribution. The .json file will be checked now with Spectral. |
"content": { | ||
"application/json": { | ||
"schema": { | ||
"$ref": "#/components/schemas/UsagenotificationRequest" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Por que remover o schema? Isso não é uma boa prática e só torna o arquivo repetitivo
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Esta informação não se repete não havendo a necessidade do uso do schema por links, aqui foi colocado o conteúdo do schema fazendo com que essa informação esteja mais próxima do endpoint (local onde ele é usado). O schemas que se repetem foram mantidos.
@@ -8500,278 +9341,6 @@ | |||
} | |||
} | |||
}, | |||
"PricebycontextRequest": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Não recomendo deletar esse e outros schemas. Os schemas servem justamente para evitar repetições no arquivo e criar uma referência única. Acho que vale inclusive adicionar mais informações em schemas nesse arquivo.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O schema foi removido e levada para o local onde havia o link no endpoint pois essa informacao não se repete, neste caso levei para o local de uso pois facilita o entendimento do endpoint quando ao se navegar pela documentação, visto que todas suas informacoes estão proxima.
Em informações que se repete eu mantive os schema, e aos poucos pretendo criar outros schema quando fizer sentido.
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
@@ -1774,18 +1794,38 @@ | |||
}, | |||
"listSku1BuyTogether": { | |||
"type": "array", | |||
"description": "SKU first list for the promotion **Buy Together**.", | |||
"description": "Array of objects, each containing ID and Name of an SKU to be added in the first list of the **Buy Together** promotion. Learn more about this type of promotion in the [Creating a Buy Together promotion](https://help.vtex.com/en/tutorial/buy-together--tutorials_323) documentation.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
O que significa "the first list of the Buy Together promotion"? (se for alterar aqui para explicar melhor, precisa alterar em todos os lugares onde essa descrição aparece)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trata-se de um array que contém uma lista de SKU, adicionado na primeira lista da promoção compre junto.
Co-authored-by: Júlia Rabello <[email protected]>
Co-authored-by: Júlia Rabello <[email protected]>
…com:vtex/openapi-schemas into EDU-10351-23H2KR5-Promotions-&-Taxes-API-B1
Co-authored-by: Júlia Rabello <[email protected]>
…51-23H2KR5-Promotions-&-Taxes-API-B1
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, mas falta resolver os erros do Spectral em um PR futuro.
Types of changes
Changelog
Do not forget to update your changes to our Developer Portal's changelog. Did you create a release note?