Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: state for className #198

Open
wants to merge 2 commits into
base: 3.x
Choose a base branch
from

Conversation

beatrizmaselli
Copy link

What is the purpose of this pull request?

Add additional classNames to the styleguide inputs. It will bring a possibility to customize the label color or position.

What problem is this solving?
In the design concept of our client the field label should have a red color when the field fails validation and since the label tag is on the upper level then input tag that has validation text, it's impossible to style it via CSS.

How should this be manually tested?
Just to check that these additional classNames are presented in the address form field HTML

Types of changes

  • Bug fix (a non-breaking change which fixes an issue)
  • New feature (a non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Requires change to documentation, which has been updated accordingly.

Copy link

vtex-io-ci-cd bot commented Sep 12, 2024

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@beatrizmaselli beatrizmaselli changed the title add state for className Add: state for className Sep 12, 2024
Copy link

@wagnerlduarte wagnerlduarte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@beatrizmaselli Do you have a workspace, image or screencast of these new css classes operating?
It could impact any other accounts for some reason?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants