Add equivalent check to validate admin endpoint (#131)

vtnerd · Sep 10, 2024 · c37b2de · c37b2de
1 parent bf8e5e2
commit c37b2de
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/src/rpc/admin.cpp b/src/rpc/admin.cpp
@@ -288,8 +288,14 @@ namespace lws { namespace rpc
     db::account_address address{};
     crypto::secret_key view_key{};
 
-    if (!convert_key(dest, address.spend_public, req.spend_public_hex, "spend_public_hex"))
+    if (req.spend_public_hex == req.view_public_hex)
+    {
+      output_error(dest, "spend_public_hex", "spend_public_hex and view_public_hex should not be equal");
       return success(); // error is delivered in JSON as opposed to HTTP codes
+    }
+
+    if (!convert_key(dest, address.spend_public, req.spend_public_hex, "spend_public_hex"))
+      return success();
     if (!convert_key(dest, address.view_public, req.view_public_hex, "view_public_hex"))
       return success();
     if (!convert_key(dest, unwrap(unwrap(view_key)), req.view_key_hex, "view_key_hex"))