Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for remote scanning via custom TCP #118

Merged
merged 1 commit into from
Sep 22, 2024

Conversation

vtnerd
Copy link
Owner

@vtnerd vtnerd commented May 29, 2024

This is the first cut at remote scanning in LWS. It took a while to complete because a custom TCP implementation using ASIO was done - ZMQ sockets were too limited in their capabilities for the task.

There's lots of code here, so I will leave for a bit as I perform additional testing on this, including performance tests. I'm still uncertain on how this will perform with lots of accounts, etc.

@vtnerd vtnerd force-pushed the feature/enterprise_scanning_squashed branch 2 times, most recently from ca4e694 to 41c27f2 Compare May 30, 2024 01:11
@vtnerd vtnerd force-pushed the feature/enterprise_scanning_squashed branch from 41c27f2 to 8ab23c9 Compare June 13, 2024 18:47
@vtnerd
Copy link
Owner Author

vtnerd commented Jun 13, 2024

This last force push:

  • Rebased against develop
  • Fixed exception bug for socket.remote_endpoint calls
  • Fixed exception bug for socket.close calls
  • Called socket.shutdown before socket.close for better platform compliance
  • Use libsodium password hashing library and memory compare to prevent password leakage.

@vtnerd
Copy link
Owner Author

vtnerd commented Jun 14, 2024

Finally ran a timed comparison test with 1000 accounts. A Ryzen 3900x saw a 5 minute drop in scan time when two laptops were added to the mix. The laptops took longer, but that is only due to the comparatively slower single threaded CPU performance. The added stress on momerod didn't impact performance negatively.

Looks like this patch will be merged, as it works as expected. I may tweak some of the parameters - most notably the threshold for remote scanning to be initiated.

@vtnerd vtnerd merged commit 9868fd9 into develop Sep 22, 2024
10 checks passed
@vtnerd vtnerd deleted the feature/enterprise_scanning_squashed branch September 22, 2024 23:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant