Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add @vuemap/vue-amap #4210

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add @vuemap/vue-amap #4210

wants to merge 1 commit into from

Conversation

yangyanggu
Copy link

@yangyanggu yangyanggu commented Nov 25, 2024

General

✏️ Mark the necessary items without changing the structure of the PR template.

  • Pull request template structure not broken

Type

ℹ️ What types of changes does your code introduce?

👉 add @vuemap/vue-amap

  • Fix
  • Feature

Checklist

ℹ️ Check all checkboxes - this will indicate that you have done everything in accordance with the rules in CONTRIBUTING.

👉 Put an x in the boxes that apply.

  • Title as described
  • Make sure you put things in the right category!
  • Always add your items to the end of a list

Open Source

  • Link description does not contain a link to an author / third-party resource
  • The documentation (README) contains a description of the project, illustration of the project with a demo or screenshots and a CONTRIBUTING section
  • The documentation is in English.
  • The project is active and maintained.
  • The project accepts contributions.
  • Not a commercial product

Apps/Websites

  • The website is available without errors or ssl certificate problems, and load in a reasonable amount of time.
  • The website is using vuejs intensively. It should detect vue with vue-devtools.

    If you cannot detect vue with vue-devtools due to work at non public pages (e.g. for enterprise website), you can send Pull Request with screenshot that detected it.

  • The website is original and not too simple. For that reason, blogs and simple landing pages are rejected.
  • A commercial product using Vue, provided that guests could reasonably check out how Vue was used (i.e. A headless CMS which uses Vue for the Admin/editor Area and offers a free tier).

@Jogai
Copy link
Collaborator

Jogai commented Dec 4, 2024

Rule not followed: 'The documentation is in English'; Which makes it really hard to review (for me)

@yangyanggu
Copy link
Author

This is a map component used in China, so the document content is all in Chinese

@Jogai
Copy link
Collaborator

Jogai commented Dec 5, 2024

Still, I cant judge the quality this way.

@yangyanggu
Copy link
Author

So, do I need to provide an English version of the readme or do I also need to translate the document into English? As the document is only provided to Chinese developers, translating English documents is meaningless to me and requires a lot of work

@Jogai
Copy link
Collaborator

Jogai commented Dec 6, 2024

An english readme would make it qualify yes.

@yangyanggu
Copy link
Author

Hello,I have added the English README, could you please take a look when you have time.
https://github.com/yangyanggu/vue-amap/blob/dev/README_en.md

@Jogai
Copy link
Collaborator

Jogai commented Dec 7, 2024

Looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants