Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compiler-sfc): initialize scope with null prototype object #11963

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

KazariEX
Copy link
Contributor

@KazariEX KazariEX commented Sep 18, 2024

Prevent mistakenly identifying properties such as toString inherited from Object as props.

Copy link

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB 37.9 kB 34.1 kB
vue.global.prod.js 159 kB 57.9 kB 51.4 kB

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.8 kB 18.8 kB 17.2 kB
createApp 55.4 kB 21.3 kB 19.4 kB
createSSRApp 59.4 kB 23 kB 21 kB
defineCustomElement 60.2 kB 22.9 kB 20.9 kB
overall 69.1 kB 26.4 kB 24 kB

Copy link

pkg-pr-new bot commented Sep 18, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11963

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11963

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11963

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11963

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11963

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11963

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11963

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11963

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11963

vue

pnpm add https://pkg.pr.new/vue@11963

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11963

commit: 71a2db4

@edison1105 edison1105 added ready to merge The PR is ready to be merged. 🧹 p1-chore Priority 1: this doesn't change code behavior. easy to merge labels Sep 18, 2024
@yyx990803 yyx990803 merged commit 215e154 into vuejs:main Sep 20, 2024
13 checks passed
@KazariEX KazariEX deleted the fix/destructured-props-null-scope branch September 20, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 p1-chore Priority 1: this doesn't change code behavior. easy to merge ready to merge The PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants