Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reactivity): cleanup subsHead in DEV and remove dep from depsMap #11971

Closed
wants to merge 1 commit into from

Conversation

edison1105
Copy link
Member

@edison1105 edison1105 commented Sep 19, 2024

close #11956
close #11979

Copy link

github-actions bot commented Sep 19, 2024

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 101 kB (+54 B) 38 kB (+18 B) 34.2 kB (-27 B)
vue.global.prod.js 160 kB (+54 B) 57.9 kB (+18 B) 51.5 kB (+75 B)

Usages

Name Size Gzip Brotli
createApp (CAPI only) 48.9 kB (+54 B) 18.8 kB (+16 B) 17.2 kB (+26 B)
createApp 55.5 kB (+54 B) 21.3 kB (+17 B) 19.5 kB (+78 B)
createSSRApp 59.5 kB (+54 B) 23 kB (+17 B) 20.9 kB (-26 B)
defineCustomElement 60.2 kB (+54 B) 22.9 kB (+20 B) 20.8 kB (+18 B)
overall 69.2 kB (+54 B) 26.4 kB (+17 B) 24 kB (+74 B)

Copy link

pkg-pr-new bot commented Sep 19, 2024

Open in Stackblitz

@vue/compiler-core

pnpm add https://pkg.pr.new/@vue/compiler-core@11971

@vue/compiler-dom

pnpm add https://pkg.pr.new/@vue/compiler-dom@11971

@vue/compiler-sfc

pnpm add https://pkg.pr.new/@vue/compiler-sfc@11971

@vue/reactivity

pnpm add https://pkg.pr.new/@vue/reactivity@11971

@vue/compiler-ssr

pnpm add https://pkg.pr.new/@vue/compiler-ssr@11971

@vue/runtime-core

pnpm add https://pkg.pr.new/@vue/runtime-core@11971

@vue/runtime-dom

pnpm add https://pkg.pr.new/@vue/runtime-dom@11971

@vue/server-renderer

pnpm add https://pkg.pr.new/@vue/server-renderer@11971

@vue/shared

pnpm add https://pkg.pr.new/@vue/shared@11971

vue

pnpm add https://pkg.pr.new/vue@11971

@vue/compat

pnpm add https://pkg.pr.new/@vue/compat@11971

commit: c1b1398

This was referenced Sep 19, 2024
@edison1105 edison1105 changed the title fix(reactivity): cleanup subsHead in DEV fix(reactivity): cleanup subsHead in DEV and remove dep from depsMap Sep 20, 2024
@edison1105 edison1105 marked this pull request as draft September 20, 2024 07:26
@edison1105 edison1105 marked this pull request as ready for review September 20, 2024 08:37
@edison1105 edison1105 force-pushed the edison/fix/11956 branch 2 times, most recently from 57f593a to c1b1398 Compare September 20, 2024 09:28
@yyx990803 yyx990803 closed this in 235ea47 Sep 20, 2024
@yyx990803
Copy link
Member

I stored the necessary information as properties on Dep in 235ea47 - this avoids the cleanup function capturing the entire closure in track and uses less memory.

@edison1105 edison1105 deleted the edison/fix/11956 branch September 20, 2024 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dep leak for property keys Vue 3.5.6 memory leaks
2 participants