Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow module to install pinia alongside #2846

Merged
merged 1 commit into from
Nov 28, 2024
Merged

fix: allow module to install pinia alongside #2846

merged 1 commit into from
Nov 28, 2024

Conversation

posva
Copy link
Member

@posva posva commented Nov 28, 2024

This should allow the nuxt module to install pinia if needed

Fix #2820

This should allow the nuxt module to install pinia if needed

Fix #2820
Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit 37c1848
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/674848a3cad1b600082f27af

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for pinia-playground canceled.

Name Link
🔨 Latest commit 37c1848
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/674848a3a81b440008f74e54

Copy link

pkg-pr-new bot commented Nov 28, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@pinia/nuxt@2846
npm i https://pkg.pr.new/pinia@2846
npm i https://pkg.pr.new/@pinia/testing@2846

commit: 37c1848

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.60%. Comparing base (e15ae89) to head (37c1848).
Report is 2 commits behind head on v2.

Additional details and impacted files
@@           Coverage Diff           @@
##               v2    #2846   +/-   ##
=======================================
  Coverage   88.60%   88.60%           
=======================================
  Files          19       19           
  Lines        1439     1439           
  Branches      227      227           
=======================================
  Hits         1275     1275           
  Misses        162      162           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posva posva merged commit 3e8ed69 into v2 Nov 28, 2024
10 checks passed
@posva posva deleted the fix/nuxt-build branch November 28, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pinia nuxt version 0.6.0+ causes error when used with pnpm monorepo
1 participant