Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: writable computeds to be picked up by mapWritableState #2847

Merged
merged 4 commits into from
Nov 29, 2024

Conversation

noootwo
Copy link
Contributor

@noootwo noootwo commented Nov 28, 2024

resolve #2823

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for pinia-playground ready!

Name Link
🔨 Latest commit b953287
🔍 Latest deploy log https://app.netlify.com/sites/pinia-playground/deploys/67498fb7a3b78600085fc57d
😎 Deploy Preview https://deploy-preview-2847--pinia-playground.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Nov 28, 2024

Deploy Preview for pinia-official canceled.

Name Link
🔨 Latest commit b953287
🔍 Latest deploy log https://app.netlify.com/sites/pinia-official/deploys/67498fb7441bb40008c3c3ed

Copy link

pkg-pr-new bot commented Nov 28, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@pinia/nuxt@2847
npm i https://pkg.pr.new/pinia@2847
npm i https://pkg.pr.new/@pinia/testing@2847

commit: b953287

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.51%. Comparing base (4715104) to head (b953287).
Report is 2 commits behind head on v2.

Additional details and impacted files
@@            Coverage Diff             @@
##               v2    #2847      +/-   ##
==========================================
+ Coverage   88.45%   88.51%   +0.05%     
==========================================
  Files          19       19              
  Lines        1447     1454       +7     
  Branches      228      228              
==========================================
+ Hits         1280     1287       +7     
  Misses        166      166              
  Partials        1        1              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@posva
Copy link
Member

posva commented Nov 28, 2024

Nice!

Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

packages/pinia/src/types.ts Outdated Show resolved Hide resolved
@noootwo noootwo force-pushed the feat/map-writable-state branch from 5f1e818 to 9c5b598 Compare November 29, 2024 04:51
@noootwo noootwo requested a review from posva November 29, 2024 04:53
packages/pinia/test-dts/mapHelpers.test-d.ts Outdated Show resolved Hide resolved
packages/pinia/__tests__/mapHelpers.spec.ts Outdated Show resolved Hide resolved
@noootwo noootwo requested a review from posva November 29, 2024 09:58
Copy link
Member

@posva posva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@posva posva merged commit 0fa633e into vuejs:v2 Nov 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow writable computeds to be picked up by mapWritableState
2 participants