Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(patch): Do not consider nodes with different scope ids the same (fix #10416) #12938

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

NoahKa0
Copy link

@NoahKa0 NoahKa0 commented Jan 18, 2023

When patching a node the scope id might change. When it does the flow should be followed for updating non-same elements to make sure it is updated correctly in the DOM.

fix #10416

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

There seems to be an issue with the tests that is not related to this change. From what I can see all tests are passing since there are some issues with the tests it might be worth double checking.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

When patching a node the scope id might change. When it does the flow should be followed for
updating non-same elements to make sure it is updated correctly in the DOM.

fix vuejs#10416
@webbseo
Copy link

webbseo commented Jan 24, 2023

what do you?

@achung89
Copy link

achung89 commented Aug 7, 2023

Any updates on this? I applied this locally and which seems to have fixed the bug for me.

@romoncorvo
Copy link

Any updates? Also fixes the bug locally for me.

@andelizondo
Copy link

Same here...

@dechaunb
Copy link

dechaunb commented Aug 2, 2024

Same here!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants