perf(bundler-webpack): use modern compiler for sass

vuepress · Jul 13, 2024 · 7b52027 · 7b52027
1 parent e3ed143
commit 7b52027
Show file tree

Hide file tree

Showing 4 changed files with 235 additions and 7 deletions.
diff --git a/e2e/package.json b/e2e/package.json
@@ -20,7 +20,7 @@
     "@vuepress-e2e/style-exports": "file:./modules/style-exports",
     "@vuepress/bundler-vite": "workspace:*",
     "@vuepress/bundler-webpack": "workspace:*",
-    "sass": "^1.77.6",
+    "sass-embedded": "^1.77.6",
     "sass-loader": "^14.2.1",
     "vue": "^3.4.29",
     "vuepress": "workspace:*"

diff --git a/packages/bundler-webpack/src/config/handleModuleStyles.ts b/packages/bundler-webpack/src/config/handleModuleStyles.ts
@@ -96,14 +96,20 @@ export const handleModuleStyles = ({
     lang: 'scss',
     test: /\.scss$/,
     loaderName: 'sass-loader',
-    loaderOptions: options.scss,
+    loaderOptions: {
+      api: 'modern-compiler',
+      ...options.scss,
+    },
   })
 
   handleStyle<SassLoaderOptions>({
     lang: 'sass',
     test: /\.sass$/,
     loaderName: 'sass-loader',
-    loaderOptions: options.sass,
+    loaderOptions: {
+      api: 'modern-compiler',
+      ...options.sass,
+    },
   })
 
   handleStyle<LessLoaderOptions>({

diff --git a/packages/bundler-webpack/src/types.ts b/packages/bundler-webpack/src/types.ts
@@ -123,6 +123,7 @@ export interface StylusLoaderOptions extends LoaderOptions {
  * @see https://github.com/webpack-contrib/sass-loader#options
  */
 export interface SassLoaderOptions extends LoaderOptions {
+  api?: 'legacy' | 'modern' | 'modern-compiler'
   implementation?: Record<string, any> | string
   sassOptions?: StylePreprocessorOptions
 }

diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml