feat(markdown): add title support for code blocks (close #1277) #1456
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
Add support for being able to set a title for code blocks (e.g. a filename).
In case the
data-ext
attribute was being used for something else in a theme I added a newdata-title
attribute for the title and its value falls back to be the same asdata-ext
if an explicit title is not specified.I opted to use enclose the title in
<
and>
instead of square brackets so it would also easily work with the import code plugin which is already using square brackets.Example
Tests have also been updated.
If we like this approach I can create a PR in
theme-default
to change the css to pull from thedata-title
attribute and update the docs.closes #1277
Screenshots
Before
After