-
Notifications
You must be signed in to change notification settings - Fork 922
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(markdown): remove codePlugin and add vPrePlugin (close #1550) #1556
Merged
Merged
Changes from 8 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
4091069
feat: deprecated `markdown.code`, migrate to the ecosystem
pengzhanbo 9bde4f5
chore:tweak
pengzhanbo e909bfb
feat: remove codePlugin
pengzhanbo c91ea44
feat: remove codePlugin
pengzhanbo ba9db9f
chore: tweak
pengzhanbo c2da2c7
Merge branch 'main' into codePlugin
pengzhanbo 395d63c
feat: add vPrePlugin
pengzhanbo 3ce4959
chore: tweak
pengzhanbo 0d91448
Merge branch 'main' into codePlugin
Mister-Hope 4b276a6
test: add e2e test with vPre plugin in importCodePlugin
Mister-Hope 7a94405
chore: tweaks
meteorlxy c787268
chore: tweaks
meteorlxy 785652e
Merge remote-tracking branch 'origin/main' into pr/pengzhanbo/1556
meteorlxy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
This file was deleted.
Oops, something went wrong.
34 changes: 0 additions & 34 deletions
34
packages/markdown/src/plugins/codePlugin/resolveHighlightLines.ts
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have we updated the docs? Or maybe we need to link to plugin docs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, I will open a pr for this, note a route related pr is open a few days ago not not being merged.