-
Notifications
You must be signed in to change notification settings - Fork 920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix route resolving error with hash and queries (close #1561) #1562
Conversation
Pull Request Test Coverage Report for Build 9248171287Details
💛 - Coveralls |
changing fullPath to path in client/dist/app.js like so fixes the issue with query strings Not sure what's the exact difference and why it worked up to rc8 (at least) and broke with rc11 you have Will fix hash but not query parms, right? |
The bug was caused by the fact that vuepress internally needs to resolve the route to obtain the route instance through You can refer to the changes made in this PR submission for more information. |
I updated the pr to improve the original fix performance. Also now API are unified to avoid misleading.
|
700f780
to
edd2fc1
Compare
6b70610
to
46bd7ba
Compare
c2b0500
to
c72ad20
Compare
Before submitting the PR, please make sure you do the following
close #123
).What is the purpose of this pull request?
Description
fix: #1561