-
Notifications
You must be signed in to change notification settings - Fork 921
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core)!: remove headers field from page data #1613
base: main
Are you sure you want to change the base?
Conversation
Pull Request Test Coverage Report for Build 12197253368Details
💛 - Coveralls |
Then the |
Could headers be server-side rendered after the change? |
I think the header information might still be required on the page object, but we should no longer pass it to client data by default. |
I see. What about SSR? Seems that helper pkg is using DOM api to get headers. |
A toc is not needed for ssr I think. |
I think this can be merged |
This reduces page data size by removing headers info from page data, downstream themes can infer headers via dom structure with
@vuepress/helper
and they can manually write it to page data if necessary.