-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add plugin-icon #319
Conversation
@pengzhanbo Please review this and see if you can accept to use this plugin in your theme. Our goal is to generate a usable icon plugin across themes. I don't think adding full package support for iconify is needed.
So I would suggest using the recommend way that iconify icon suggest, rather than supporting https://theme-plume.vuejs.press/guide/features/icon/#%E5%8A%A0%E8%BD%BD%E5%9B%BE%E6%A0%87 Note: We can support |
Pinging @recoluan for your theme-reco as well |
Good job! |
@Mister-Hope First of all, this plugin is great, but I have reservations about fully loading icon resources via CDN. In my practical application scenarios, as well as feedback from some users, it is quite common to have completely isolated external network connections within corporate intranets, which makes it impossible to load icon resources correctly in such cases. On the other hand, when there are a large number of icons present in the visible area of the site, it triggers a significant number of icon requests. Due to the browser's limitations on concurrent requests, this can lead to frequent UI flickering. |
I decide to add this first. The next target is to support markdown grammar with it. Then we can see if we can add built-in icons support for iconify. For the grammar, I would prefer |
@Mister-Hope
|
No description provided.