Fix Language Menu for Records with Slashes #1596
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Running full headless tests. |
|
Thanks, @crhallberg, this sent me on a deep dive into Zend/Laminas code, which revealed a simpler solution: disable the normalize_path option. I've implemented that fix at commit 8c61eb2, so I'm going to close this PR. |
|
This Laminas issue may be of some interest too: laminas/laminas-router#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Core Problem: Adding parameters and invoking the URL helper with
nullname and[]parameters causes the base URL to lose escaping.Solution: escape id parameters for the path name. This solution feels a little too narrow but is a starting point for solving the issue.
Fixes VUFIND-1392