Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve theme initializer #4158

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented Dec 10, 2024

This PR does some cleanup to the theme initializer, suggested by discussion on #4155:

  • Eliminates the enable/enabled methods of VuFindTheme\Mobile, as this actually made the code less clear rather than more clear
  • Clarifies the flow of theme-related settings to better differentiate the user-provided "ui" setting from the actual theme that resolves to
  • Reduces unnecessary hard-coded fully-qualified class names in code

TODO

  • Update changelog when merging (note methods removed from VuFindTheme\Mobile and internal signature changes in VuFindTheme\Initializer).

@demiankatz demiankatz added the architecture pull requests that involve significant refactoring / architectural changes label Dec 10, 2024
@demiankatz demiankatz added this to the 11.0 milestone Dec 10, 2024
@demiankatz demiankatz merged commit d796e30 into vufind-org:dev Dec 11, 2024
6 checks passed
@demiankatz demiankatz deleted the improve-theme-initializer branch December 11, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
architecture pull requests that involve significant refactoring / architectural changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants