Disable turnstile globally, or if redis is selected for storage #4164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Makes sense to me, but I'll wait for this to come out of draft and get feedback from @EreMaijala before merging it.
|
Even if we do support redis when installed (which is now on my todo list), it's also a win here remove the constructor dependency as @demiankatz suggested, and also to make it easier to globally disable turnstile in one place if you have multiple policies, and to avoid the minor resource usage of constructing the turnstile cache if it's not actually going to be needed. |
EreMaijala
requested changes
Dec 16, 2024
demiankatz
reviewed
Dec 16, 2024
EreMaijala
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.