Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove useless and invalid pagination color overrides. #4177

Conversation

EreMaijala
Copy link
Contributor

  • The settings were not needed because the default is already $primary (or $brand-primary in bootstrap 3).
  • The settings in bootstrap5's variables.scss were invalid as $brand-primary (a BS3 thing) isn't actually defined (but !default masked the mistake).

- The settings were not needed because the default is already $primary.
- The settings in bootstrap5 variables.scss were invalid as $brand-primary (a BS3 thing) isn't actually defined (but !default masked the mistake).
@EreMaijala EreMaijala requested a review from demiankatz January 3, 2025 14:25
@demiankatz demiankatz added this to the 10.1.1 milestone Jan 3, 2025
Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @EreMaijala!

@demiankatz demiankatz merged commit f5f9ec2 into vufind-org:release-10.1 Jan 3, 2025
6 checks passed
@demiankatz demiankatz deleted the release-10.1-fix-bs5-pagination-vars branch January 3, 2025 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants