Adjust Feedback/form.phtml to allow overriding the default action route #4187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm, some odd deprecations, nvm watched the wrong errors.. |
demiankatz
requested changes
Jan 16, 2025
|
|
||
| $formUrl = $this->url('feedback-form', ['id' => $this->formId]); | ||
| $formUrl = $this->url($this->formActionUrl ?? 'feedback-form', ['id' => $this->formId]); |
There was a problem hiding this comment.
Where is formActionUrl set? Should this actually be $this->formActionUrl ?? $this->url(...) so you override the actual URL instead of the route name? If not, should the variable be named formActionRoute instead?
There was a problem hiding this comment.
hmm, actually setting the route in feedbackform yaml could be enough as everything else can be otbained from params and yaml, added a function for it now :) Gonna add a comment for it also
demiankatz
approved these changes
Jan 16, 2025
demiankatz
changed the title
1 task
LuomaJuha
added a commit
to NatLibFi/NDL-VuFind2
that referenced
this pull request
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.