Check ints for the end of string before seperator #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Brendan, please cover this use-case by tests |
b0d0nne11
force-pushed
the
brendan/fix-int-matcher
branch
from
726d5fd to
58a715c
Compare
b0d0nne11
force-pushed
the
brendan/fix-int-matcher
branch
from
58a715c to
1db90db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an integer matcher is the final element of a Trie it interprets the null at the end of the string as a separator character and pushes it back onto the iterator. Then the iterator containing a single null character fails to match the rest of the Trie. The string matcher on the other hand checks for the end of the string first and then checks for a separator character. This PR makes the behavior of the integer matcher the same as the string matcher by checking for the end of string first.