-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consolidate pagination metadata nil pointer checks #410
Consolidate pagination metadata nil pointer checks #410
Conversation
… nil pointer checks
Unit Tests and CoverageShow Output
Pusher: @PaulSonOfLars, Action: |
@PaulSonOfLars I like what you're doing here. Thanks for submitting the PR. I'm gonna look at this more closely and think it through. It's probably going to need a rebase once my PR goes in, so if you want to hold off to push the lint fixes until then, that'd be swell. |
@optik-aper no problem! |
Just merged it! |
Unit Tests and CoverageShow Output
Pusher: @PaulSonOfLars, Action: |
Unit Tests and CoverageShow Output
Pusher: @PaulSonOfLars, Action: |
Unit Tests and CoverageShow Output
Pusher: @PaulSonOfLars, Action: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems a little redundant but I think this is a good safety mechanism to check for nil
structs. I'm merging it and might tweak it in the future. Thanks for the PR
Description
Consolidate pagination metadata nil pointer checks, fixing a panic in the region availability lists (#408)
Related Issues
Fixes #408
Checklist: