Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect govultr delete method for VPC2 #426

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented Mar 11, 2024

Description

Fix incorrect govultr delete method for VPC2. Previously this error was thrown on any and all VPC2 deletes:

Error: error deleting vpc2 : {"error":"Invalid private network ID.","status":404}
exit status 1

Testing instructions

Make sure a VPC2 can be deleted

go run main.go vpc2 delete UUID_HERE

Related Issues

Fixes #424

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper optik-aper added the regression Something that worked doesn't work after changes label Mar 11, 2024
@optik-aper optik-aper self-assigned this Mar 11, 2024
Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @optik-aper, Action: pull_request_target

@optik-aper optik-aper merged commit 2d50677 into vultr:master Mar 11, 2024
4 checks passed
@optik-aper optik-aper mentioned this pull request Mar 12, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Something that worked doesn't work after changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - vpc2 delete -> 404
2 participants