Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add mdisk_mode flag for baremetal create #449

Merged
merged 2 commits into from
Jun 11, 2024
Merged

add mdisk_mode flag for baremetal create #449

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
44d416f
add mdisk_mode flag for baremetal create
May 29, 2024
d2f645d
Update mdiskMode name to match convention
fjoenichols Jun 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 18 additions & 6 deletions cmd/baremetal/baremetal.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ func NewCmdBareMetal(base *cli.Base) *cobra.Command { //nolint:funlen,gocyclo
create.Flags().StringSliceP("tags", "", []string{}, "(optional) A comma separated list of tags to assign to the server.")
create.Flags().StringP("ripv4", "v", "", "(optional) IP address of the floating IP to use as the main IP of this server.")
create.Flags().BoolP("persistent_pxe", "x", false, "enable persistent_pxe | true or false")

create.Flags().StringP("mdisk_mode", "", "", "(optional) The raid configuration to use when provisioning this server. Possible values: 'raid1', 'jbod', 'none''. Defaults to 'none'.")
if err := create.MarkFlagRequired("region"); err != nil {
fmt.Printf("error marking bare metal create 'region' flag required: %v", err)
os.Exit(1)
Expand Down Expand Up @@ -1145,6 +1145,11 @@ func parseCreateFlags(cmd *cobra.Command) (*govultr.BareMetalCreate, error) { //
return nil, fmt.Errorf("error parsing ripv4 flag for bare metal create : %v", err)
}

mdiskMode, err := cmd.Flags().GetString("mdisk_mode")
if err != nil {
return nil, fmt.Errorf("error parsing mdisk_mode flag for bare metal create : %v", err)
}

pxe, err := cmd.Flags().GetBool("persistent_pxe")
if err != nil {
return nil, fmt.Errorf("error parsing persistent_pxe flag for bare metal create : %v", err)
Expand All @@ -1169,6 +1174,7 @@ func parseCreateFlags(cmd *cobra.Command) (*govultr.BareMetalCreate, error) { //
ReservedIPv4: ripv4,
Region: region,
PersistentPxe: govultr.BoolToBoolPtr(pxe),
MdiskMode: mdiskMode,
}
if userdata != "" {
options.UserData = base64.StdEncoding.EncodeToString([]byte(userdata))
Expand Down Expand Up @@ -1216,12 +1222,18 @@ func parseUpdateFlags(cmd *cobra.Command) (*govultr.BareMetalUpdate, error) { //
return nil, fmt.Errorf("error parsing image flag for bare metal update : %v", err)
}

mdiskMode, err := cmd.Flags().GetString("mdisk_mode")
if err != nil {
return nil, fmt.Errorf("error parsing image mdisk_mode for bare metal update : %v", err)
}

options := &govultr.BareMetalUpdate{
AppID: app,
OsID: osID,
ImageID: image,
Label: label,
Tags: tags,
AppID: app,
OsID: osID,
ImageID: image,
Label: label,
Tags: tags,
MdiskMode: mdiskMode,
}
if userdata != "" {
options.UserData = base64.StdEncoding.EncodeToString([]byte(userdata))
Expand Down
Loading