Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make dns record create priority and ttl flags opt #468

Merged

Conversation

optik-aper
Copy link
Member

@optik-aper optik-aper commented Jul 29, 2024

Description

  • Make the priority and ttl flags on a DNS record optional
  • Set default value of priority to -1, mirroring the API behavior

Related Issues

Resolves #467

Checklist:

  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?
  • Have you linted your code locally prior to submission?
  • Have you successfully ran tests with your changes locally?

@optik-aper optik-aper added the bug Something isn't working label Jul 29, 2024
@optik-aper optik-aper self-assigned this Jul 29, 2024
Copy link

Unit Tests and Coverage

Show Output
?   	github.com/vultr/vultr-cli/v3	[no test files]

Pusher: @optik-aper, Action: pull_request_target

@optik-aper optik-aper requested a review from mondragonfx July 29, 2024 18:16
Copy link
Contributor

@mondragonfx mondragonfx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@optik-aper optik-aper merged commit 9ff0a7d into vultr:master Jul 29, 2024
4 checks passed
@optik-aper optik-aper mentioned this pull request Jul 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] - creating A and CNAME records fail without setting priority
2 participants