refactor[test]: add sanity checks to abi decode tests #4096
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: trocher <[email protected]>
--------- Co-authored-by: trocher <[email protected]>
it is redundant now with the make_setter checks!
Co-authored-by: trocher <[email protected]>
Co-authored-by: trocher <[email protected]>
Co-authored-by: trocher <[email protected]>
cyberthirst
force-pushed
the
abi-decode-sanity-checks
branch
from
5650c70
to
a58fda0
Compare
| # parent payload - this word will be considered as the head of the abi-encoded inner array | ||
| # and it will be added to base ptr leading to an arithmetic overflow | ||
| 2**256 - 0x60, | ||
| 2**256 | ||
| - 0x60, |
There was a problem hiding this comment.
result of linting
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4096 +/- ##
==========================================
- Coverage 91.32% 90.42% -0.90%
==========================================
Files 109 109
Lines 15557 15557
Branches 3416 3416
==========================================
- Hits 14207 14067 -140
- Misses 920 1032 +112
- Partials 430 458 +28 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture