fix[codegen]: order of eval for some builtins #4156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
--------- Co-authored-by: trocher <[email protected]>
--------- Co-authored-by: cyberthirst <[email protected]>
--------- Co-authored-by: trocher <[email protected]>
fubuloubu
approved these changes
Jun 18, 2024
cyberthirst
reviewed
Sep 16, 2024
| @@ -1103,6 +1103,14 @@ def ensure_in_memory(ir_var, context): | |||
| return IRnode.from_list(["seq", do_copy, buf], typ=typ, location=MEMORY) | |||
|
|
|||
|
|
|||
| # TODO: refactor ensure_in_memory to use this function | |||
There was a problem hiding this comment.
can we do this within the scope of this PR?
cyberthirst
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture