feat[tool]: add all imported modules to -f annotated_ast output
#4209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4209 +/- ##
==========================================
- Coverage 91.35% 88.26% -3.10%
==========================================
Files 109 109
Lines 15635 15656 +21
Branches 3443 3448 +5
==========================================
- Hits 14283 13818 -465
- Misses 920 1306 +386
- Partials 432 532 +100 ☔ View full report in Codecov by Sentry. |
fubuloubu
approved these changes
Aug 11, 2024
pcaversaccio
approved these changes
Aug 12, 2024
cyberthirst
reviewed
Aug 27, 2024
| # come from multiple InputBundles (particularly builtin interfaces), | ||
| # so source_id is not guaranteed to be unique. | ||
| if ast.resolved_path in unique_modules: | ||
| # sanity check -- object equality |
There was a problem hiding this comment.
is operator checks for identity, not equality
There was a problem hiding this comment.
yea, that's what I meant by object ("pointer") equality
cyberthirst
reviewed
Aug 28, 2024
| annotated_ast_dict = { | ||
| "contract_name": str(compiler_data.contract_path), | ||
| "ast": ast_to_dict(compiler_data.annotated_vyper_module), | ||
| "imports": [ast_to_dict(ast) for ast in unique_modules.values()], |
There was a problem hiding this comment.
it might be confusing to have all the imports flattened into main as this also includes indirect imports
There was a problem hiding this comment.
It's a way of normalization, it avoids duplicating trees in the output
|
can we add a test for recursive imports? |
cyberthirst
approved these changes
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture