Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[tool]: add integrity hash to initcode #4234

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Sep 11, 2024

What I did

How I did it

How to verify it

Commit message

this commit adds the integrity hash of the source code to the
initcode. it extends the existing cbor metadata payload in the
initcode, so that verifiers can compare the integrity hash to the
artifact produced by a source bundle.

the integrity hash is put in the initcode to preserve bytecode space of
the runtime code.

refactor:
- change existing `insert_compiler_metadata=` flag to the more generic
`compiler_metadata=None`, which is more extensible.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@charles-cooper charles-cooper added this to the v0.4.1 milestone Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 46.18%. Comparing base (03095ce) to head (22a8655).

Files with missing lines Patch % Lines
vyper/compiler/phases.py 88.88% 0 Missing and 1 partial ⚠️

❗ There is a different number of reports uploaded between BASE (03095ce) and HEAD (22a8655). Click for more details.

HEAD has 139 uploads less than BASE
Flag BASE (03095ce) HEAD (22a8655)
140 1
Additional details and impacted files
@@             Coverage Diff             @@
##           master    #4234       +/-   ##
===========================================
- Coverage   91.35%   46.18%   -45.18%     
===========================================
  Files         109      109               
  Lines       15641    15644        +3     
  Branches     3443     3444        +1     
===========================================
- Hits        14289     7225     -7064     
- Misses        920     7865     +6945     
- Partials      432      554      +122     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper enabled auto-merge (squash) October 4, 2024 19:26
@charles-cooper charles-cooper merged commit 9655119 into vyperlang:master Oct 4, 2024
155 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants