feat[tool]: add -Werror and -Wnone options
#4447
Draft
+92
−60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which promote warnings to errors and ignore them, respectively. also some small refactoring for warning handling to simplify the implementation (allow us to use `warnings.simplefilter`).
charles-cooper
changed the title
charles-cooper
changed the title
-Werror and -Wnone options
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -11,7 +11,7 @@ | |||
| import warnings | |||
| from typing import Generic, List, TypeVar, Union | |||
|
|
|||
| from vyper.exceptions import CompilerPanic, DecimalOverrideException, VyperException | |||
| from vyper.exceptions import CompilerPanic, DecimalOverrideException | |||
Check notice
Code scanning / CodeQL
Cyclic import Note
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4447 +/- ##
===========================================
- Coverage 92.01% 57.91% -34.10%
===========================================
Files 119 119
Lines 16692 16708 +16
Branches 2805 2806 +1
===========================================
- Hits 15359 9677 -5682
- Misses 915 6352 +5437
- Partials 418 679 +261 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which promote warnings to errors and ignore them, respectively.
also some small refactoring for warning handling to simplify the implementation (allow us to use
warnings.simplefilter).What I did
How I did it
How to verify it
Commit message
Commit message for the final, squashed PR. (Optional, but reviewers will appreciate it! Please see our commit message style guide for what we would ideally like to see in a commit message.)
Description for the changelog
Cute Animal Picture