Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove node <= 16. #34

Merged
merged 1 commit into from
Jul 25, 2023
Merged

Remove node <= 16. #34

merged 1 commit into from
Jul 25, 2023

Conversation

JSAssassin
Copy link
Contributor

No description provided.

aljones15
aljones15 approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@aljones15 aljones15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM only concern is how higher node versions will hold up when generating weekly reports.

@JSAssassin
Copy link
Contributor Author

@aljones15 It has been working fine. We already use node 20 in eddsa and ecdsa test suites.

@JSAssassin JSAssassin merged commit cd9531c into main Jul 25, 2023
2 checks passed
@JSAssassin JSAssassin deleted the remove-node-16 branch July 25, 2023 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aljones15 aljones15 aljones15 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSAssassin @aljones15