Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add proof to schema for credentials intended for issuance #423

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Add proof to schema for credentials intended for issuance #423

merged 3 commits into from
Oct 22, 2024

Conversation

aljones15
Copy link
Contributor

@aljones15 aljones15 commented Sep 25, 2024 •
edited
Loading

  • Check to ensure minor changes to res-oas.js did not cause any regressions

Features:

  • Adds support for type: array to oneOf schemas
  • Adds proof to issue credential API endpoint schema
  • Redefines UnsecuredCredential in components to allow it to optionally have a proof

Addresses some, but not all of this issue: #422

@aljones15 aljones15 changed the title Add proof issuer credential Add proof to schema for credentials intended for issuance Oct 1, 2024
@aljones15 aljones15 marked this pull request as ready for review October 1, 2024 22:26
@aljones15 aljones15 marked this pull request as draft October 2, 2024 00:57
@aljones15 aljones15 marked this pull request as ready for review October 2, 2024 21:11
@msporny msporny merged commit 57b6b53 into w3c-ccg:main Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlongley dlongley dlongley approved these changes

@msporny msporny Awaiting requested review from msporny msporny is a code owner

@mavarley mavarley Awaiting requested review from mavarley mavarley is a code owner

@mkhraisha mkhraisha Awaiting requested review from mkhraisha mkhraisha is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aljones15 @dlongley @msporny