-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Infrastructure: update skipto.js to version 5.2.1 #2807
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jongund rather than add colortheme and displayoption to cspell, I think we should change the syntax to use either color-theme and display-option or colorTheme and displayOption. I am pretty sure either would get past cspell. What is your preference?
Also, a navigation region is getting wrapped around the skipto button. We don't want that. We need an option to suppress. Or, better yet, the default should be to not add it. Skipto is the first thing on the page. The nav region is not useful in practice, and it adds extra verbosity that is distracting when tabbing.
The keywords are case insenstative, so the following updated configuration should fix the cspell issue and the navigation landmark problem is fixed by adding the
|
Thanks @jongund. That solved the problems. This PR now provides the updated skipto with appropriate behaviors on all pages except for three: Since #2702, is not yet done, we will need to address the update of skipto for these three pages in wai-aria-practices via w3c/wai-aria-practices#259. We need to determine how that will be resolved before we merge this. @a11ydoer, I'm assigning you as a reviewer to look at the visual presentation and mouse behavior of this version to make sure there are no regressions or unexpected changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Navigation with keyboard only or mouse works.
@mcking65 @a11ydoer @jongund this PR has been updated with the suggested change to The preview link has also been rebuilt. |
Updated skip.js to use public distribution.
This requires scripts referencing
skipto.js
to include the following data attribute:This is related to issue 259 in wai-aria-practices repository.
WAI Preview Link (Last built on Tue, 06 Feb 2024 22:25:28 GMT).